Skip to content

Hand Subclass: The Huntsmaster#6486

Open
Spitegremlin wants to merge 34 commits into
Monkestation:mainfrom
Spitegremlin:Handsubclassanddog
Open

Hand Subclass: The Huntsmaster#6486
Spitegremlin wants to merge 34 commits into
Monkestation:mainfrom
Spitegremlin:Handsubclassanddog

Conversation

@Spitegremlin

@Spitegremlin Spitegremlin commented May 16, 2026

Copy link
Copy Markdown

About The Pull Request

Adds a new subclass for hand, called the Huntsmaster, has a hound and is bow focused, along with a new hound, and a new Gambeson

Why It's Good For The Game

Adds more choices for what you can do

Changelog

🆑
add: Added Huntsmaster Hand subclass, along with their hound
add: Added new Gambeson. Hunting Gambeson
add: Added new trait called keen eyes, and gave it to hunters and huntsmaster
add: Added a trait called flip jump to Spymaster, doesnt do anything other then let them flip when they jump
balance: gave Advisor a glock
balance: gave all hand subclasses a standard 8 since i was told too, and the default hand class had 8
balance: gave pilgrim hunter forager and keeneyes trait, to match with normal hunter
image: added/modified/removed some icons or images
code: changed some code
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@github-actions github-actions Bot added the Code Maintenance Fixing this mess one line at a time label May 16, 2026
@Spitegremlin Spitegremlin marked this pull request as draft May 16, 2026 19:11
@Spitegremlin

Spitegremlin commented May 16, 2026

Copy link
Copy Markdown
Author

NOT done yet, this is just to finish hand stuff, im going to add some advisor things (gun in a hollow book...) and make the Gambeson i made craftable

@Spitegremlin Spitegremlin marked this pull request as ready for review May 18, 2026 10:57
Comment thread code/modules/clothing/armor/gambesson.dm
Comment thread code/modules/jobs/job_types/adventurer/types/pilgrim/hunter.dm
Comment thread code/modules/jobs/job_types/nobility/hand.dm
Comment thread code/modules/jobs/job_types/nobility/hand.dm
Comment thread code/modules/jobs/job_types/nobility/hand.dm
Comment thread code/modules/jobs/job_types/peasants/hunter.dm
Comment thread code/modules/mob/living/living.dm
@realforest2001 realforest2001 marked this pull request as draft May 18, 2026 17:37
@Spitegremlin Spitegremlin marked this pull request as ready for review May 24, 2026 18:14
@Spitegremlin

Copy link
Copy Markdown
Author

I dont know why it says its failing, i heard something about some code slipping into main, thats doing that, but thats all i know

screen_max_rows = 2
screen_max_columns = 1

/datum/component/storage/concrete/grid/coin_pouch/book/hollow

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/datum/component/storage/concrete/grid/coin_pouch/book/hollow
/datum/component/storage/concrete//hollow_book

Don't just accept this change change this path in the book item

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why doesnt the current one work

/obj/item/reagent_containers/food/snacks/hardtack,
)

/obj/item/storage/belt/pouch/book/hollow

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a pouch

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

takes from pouch

mob_overlay_icon = 'icons/roguetown/clothing/special/onmob/hand.dmi'
icon = 'icons/roguetown/clothing/special/hand.dmi'
mob_overlay_icon = 'icons/roguetown/clothing/special/onmob/hand.dmi'
detail_tag = "_detail"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
detail_tag = "_detail"
detail_tag = "_detail"
detail_color = CLOTHING_WHITE

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the point of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Maintenance Fixing this mess one line at a time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants